slow editing

classic Classic list List threaded Threaded
Assigned to alehro at priority
 3 
(Normal)
11 messages Options
Reply | Threaded
Open this post in threaded view
|

slow editing

Bela
Hi,

It seems a very good and useful addon, but when I use it, it's often very slow editing messages.

Sometimes it's good, so I don't know why sometimes becomes so slow...

Any idea what can be the reason of that?

Thank you in advance,
Bela
Reply | Threaded
Open this post in threaded view
|

Re: slow editing

Bela
The error message is 'too much recursion '
Reply | Threaded
Open this post in threaded view
|

Re: slow editing

alehro
Administrator
Hi Bella,
Thank you for reporting. Unfortunately I cannot reproduce this bug. Also nobody of users of Multi-User edition has reported such problems. The code base of both editions in part of visual representation is the same. So, I'd say you hit hardly reproducible bug. The error message is too general to make any suggestions.

The perfect solution in such a cases is to connect to the buggy computer and investigate the problem by myself. But I don't think you want such a disturbance.

Also you may enable Debug option in the MNP options and look at error console (Ctrl+Shift+J). Don't forget to choose All tab. If 'too much recursion' is coming from MNP then there should be appearing endless (or quite a lot) list of messages. Don't forget to disable debug option after investigations, this option can slow down TB even more.

Also you can enable Debug option, reproduce the bug and send me messagenoteplus.log file. This file is located in TB profile directory. (The profile directory is two levels up from default MNP icons directory. Default icons directory path is on Icons tab of MNP options. I hope you like quests).

Alex

Reply | Threaded
Open this post in threaded view
|

Re: slow editing

Bela
Thank you for your answer.

I did what your wrote me and I'm sending you the .log file.

Since yesterday I know a bit more about the bug. The error produces when I write a bit longer (more than two-lines) note. It seems to me that it's somehow related to the display refreshing. As soon as the small two-lines height note field is too small, after each extra character I have to wait around 5 seconds to save it...

In the third line after pressing 'l' the error message is:

2012-11-15 22:45:15 mnp DEBUG requestDb. local. request: {"command":"save","noteObj":{"messageId":"50A3CA5F.60501@web.de","status":-4,"note":"{\"body\":\"first line + line break\\nsecond line + line break\\nthird l\",\"date\":1353015915280,\"status\":0}","lstatus":0,"nformat":1,"local_note_body":"first line + line break\nsecond line + line break\nthird l","pending":1}}
2012-11-15 22:45:15 mnp DEBUG Precreate SQL statement: UPDATE MESSAGENOTES SET messageId=:messageId,status=:status,note=:note,lstatus=:lstatus,nformat=:nformat,local_note_body=:local_note_body,pending=:pending WHERE messageId=:messageId
2012-11-15 22:45:15 mnp DEBUG handleCompletion
2012-11-15 22:45:15 mnp DEBUG Message notes plus. Data received from local db: {"success":true,"data":null,"message":""}

And after pressing 'i' the message is the same:

2012-11-15 22:45:36 mnp DEBUG requestDb. local. request: {"command":"save","noteObj":{"messageId":"50A3CA5F.60501@web.de","status":-4,"note":"{\"body\":\"first line + line break\\nsecond line + line break\\nthird li\",\"date\":1353015936910,\"status\":0}","lstatus":0,"nformat":1,"local_note_body":"first line + line break\nsecond line + line break\nthird li","pending":1}}
2012-11-15 22:45:36 mnp DEBUG Precreate SQL statement: UPDATE MESSAGENOTES SET messageId=:messageId,status=:status,note=:note,lstatus=:lstatus,nformat=:nformat,local_note_body=:local_note_body,pending=:pending WHERE messageId=:messageId
2012-11-15 22:45:36 mnp DEBUG handleCompletion
2012-11-15 22:45:36 mnp DEBUG Message notes plus. Data received from local db: {"success":true,"data":null,"message":""}

Do you have any idea ?
Bela
Roy
Reply | Threaded
Open this post in threaded view
|

Re: slow editing

Roy
In reply to this post by alehro
I am also experiencing very slow editing past the second line.
Reply | Threaded
Open this post in threaded view
|

Re: slow editing

alehro
Administrator
Thank you guys for your investigations. Unfortunately I cannot reproduce this bug on my Windows 7, but now I know almost for sure the origin of the bug. When you start adding lines (more than two lines) the note box starts auto-size himself. Actually the auto-size doesn't work even on my PC (although without lags).
I've spent a lot of time trying to tune this stuff. Now I'm going to revise it. Also I will make the auto-sizing optional.
Reply | Threaded
Open this post in threaded view
|

Re: slow editing

alehro
Administrator
@Bela, the debug messages you shown to me are okey. It is just auto-save. It should happen every time you stop editing a note with 2 seconds delay. I believe it's not related to the bug.
Reply | Threaded
Open this post in threaded view
|

Re: slow editing

alehro
Administrator
Fixed, I hope so. Please download and install it from here:
http://mnpforum.alehro00.com/file/n4638993/messagenotesplus_1.4.0.9.xpi

I would like to be sure that it works before uploading it to AMO. I still cannot reproduce the lags. Please let me know if it works or no.
Especially I would like to know:
1. If the lags are fixed.
2. If the note box is being auto-expanded.
Reply | Threaded
Open this post in threaded view
|

Re: slow editing

bela
In reply to this post by alehro
Sorry not replying earlier... No I'm back. Thank you for your answer.
Reply | Threaded
Open this post in threaded view
|

Re: slow editing

alehro
Administrator
Hi Bela,
I received your screenshots. So, the autosizing is still wrong, although I cannot say for sure what is the cause of such behavior. I'm going to make auto-sizing optional in next version. I hope it will be ready in a couple of months. I will let you know. Until then you may revert to old versions: 1.4.0.8 or 1.3.0.4 (it doesn't have autosizing, so it should behave well.) You may find all versions on AMO: https://addons.mozilla.org/en-US/thunderbird/addon/messagenotesplus/versions/
Once again thank you for the feedback.
Reply | Threaded
Open this post in threaded view
|

Re: slow editing

Mike
I have been experiencing the same problem - getting a "Thunderbird not responding" if the message is over 2 lines long. I'm on version 1.4.0.8.

I'll take your advice to revert to the earlier version until you are able to fix the problem.

Thanks for the add-on, I find it very useful and have been recommending it to friends.