Date exactly one month off?

classic Classic list List threaded Threaded
11 messages Options
Reply | Threaded
Open this post in threaded view
|

Date exactly one month off?

BobJam
Ubuntu 12.04.1 LTS, TB 16.01

Coupla' things . . . first, and perhaps slightly annoying (but NOT a dealbreaker . . . my compliments on the add on) is the date shown in the note:



This shows September (9), and it was EXACTLY 10/23/2012, 5:30:49 PM, when I made the note.  I've made more than one test note, and they all have that same date flaw.  It seems to be EXACTLY one month behind.

Now I'm not proficient in coding, but I DO have Sqliteman and HAVE looked at messagenotesplus.sqlite (never mind that I have absolutely NO idea what I'm looking at or even how to use Sqliteman.)  I'm guessing that the coding for the date is somewhere either somewhere in this db, or else in the XML itself for the add on.

So, is there some way I can fix this in the db (if it's there)?  Or do we just have to wait for an update?  Or, is this something you can't reproduce, and it's just a flaw in my installation?  (Meaning, I assume, I should try a reinstall . . . though I've done that and the date issue seems to persist.)

Again, though, compliments on your effort.  Notes add ons for TB's latest version are woefully missing (the only other one I found was "QuickNotes", and I didn't like that because it's universal, and yours is the only one I found that's specific to individual messages.)

Which is a seqway to my next question.  Do you intend to update this thing when the 17 version comes out (i.e. when Canonical releases it, which always lags the Mozilla release by a week or so)?  Yours is the only notes add on I've found that is compatible with 16.01, but I see the current offering on Mozilla goes no further.  So, if you don't keep developing this thing, then when Canonical releases 17, I'm SOL.
BJ
Reply | Threaded
Open this post in threaded view
|

Re: Date exactly one month off?

alehro
Administrator
Hi Bob,
Thank you for reporting.
Answers to your questions:

1. It's just stupid bug in my JavaScript. I'm ashamed how I missed it. I use Date's getMonth() function to retrieve an ordinal of a month. Now I look at documentation of the function and I see that it returns numbers from 0 to 11, but not from 1 to 12.
Although it's worth to mention, that the bug affects only the view part of the add-on. All dates in the database are correct. So, you may use this buggy version until new update from AMO will be available, then all dates of notes will became correct.
Anyway here is fixed version: messagenotesplus_1.4.0.6.xpi
2. Yes, I intend to update the add-on for new versions of Thunderbird. Actually, updating of the version is usually just changing one number in one place. Something like 16.* to 17.* . You may hack it yourself.

Let me know please if you need something else.
Reply | Threaded
Open this post in threaded view
|

Re: Date exactly one month off?

BobJam
Kool . . . thanks very very much for the answers AND the corrected version.

Indeed, your answers were what I hoped for.

BTW, when you say "You may hack it yourself", I assume you're talking about modifying the install.rdf XML "maximum version" and then rezipping the whole thing.

Actually, I've been curious about that.  Do you developer guys have to modify your add on code some times when Mozilla comes out with some of their new versions?

The reason I ask is because I tried the install.rdf hack on "XNotes", and it didn't work.  I'm guessing that since the XNotes maximum version was some where back at 2.0 something, the code was so antiquated that even changing the max version didn't make any difference.

Now the 1.4.0.6 version works very nicely AND the date is corrected.  Compliments and thanks again!
BJ
Reply | Threaded
Open this post in threaded view
|

Re: Date exactly one month off?

alehro
Administrator
Yes, I'm talking about install.rdf. Of course the code of the add-on itself should be compatible. Also you should install the repacked xpi through "Add-on Manager->Install from file". Dropping the xpi to the extensions folder is not enough.

Regarding XNote++ it looks up to date: https://addons.mozilla.org/en-US/thunderbird/addon/xnotepp/?src=search

The update procedure of add-ons is far from perfect. You know, AMO has automatic tests on compatibility. When new version of the Thunderbird is coming, they run the tests for every add-on, and if the tests succeed they send an email to developer of the add-on: "Congratulations we didn't discovered any compatibility issues". Here is THE trick. They do not change the compatibility version of the add-on. Imagine my shock when I come to my add-on page and see that's incompatible with current version of the TB, while they keep sending me emails: "Sleep well, your add-on is compatible" .
Reply | Threaded
Open this post in threaded view
|

Re: Date exactly one month off?

BobJam
Coupla' things on your remarks above.

First of all, when I left clicked on your link for 1.4.0.6, I got a refusal warning:  "messagenotesplus could not be installed because it is not compatible with Firefox 16.01".  At first, I thought "WTF"!

But then I right clicked it and saved the link/.xpi to my desktop (Mate).

From there I was able to do the ""Add-on Manager->Install from file" dance that you spoke of.  (I'm guessing left clicking on the link simply did the "Dropping the xpi to the extensions folder" you spoke of.)

Anyway, all went well finally.

NO, I wasn't talking about XNote++, I was talking about the OLD XNote 2.1.0 at https://addons.mozilla.org/en-US/thunderbird/addon/xnote/?src=ss

I never found XNote++ 'till you gave me the link, and yes that reflects a version that is supposed to be compatible with 16.01.  Probably just as well I didn't find it anyway, because I think your add on has better indicators right in the message, though I might have gone with XNotes++ if I had found it first.  (Do you and Froihofer swap info?  Just curious if there's a developers "grape vine".)

I'm a little confused on what you said about AMO.  You mean they don't post what you sent them, but rather post the previous "min/max" version as long as it passes their compatibility test?  (Thus it would show as incompatible with the new TB version e.g. "3.0 - 16*" would show as incompatible with TB 17.)
BJ
Reply | Threaded
Open this post in threaded view
|

Re: Date exactly one month off?

alehro
Administrator
BobJam wrote
First of all, when I left clicked on your link for 1.4.0.6, I got a refusal warning:  "messagenotesplus could not be installed because it is not compatible with Firefox 16.01".  At first, I thought "WTF"!
That's correct. Firefox cannot install Thunderbird only compatible extensions. The warning message could be more user friendly. It's another annoying behavior.
BobJam wrote
 (I'm guessing left clicking on the link simply did the "Dropping the xpi to the extensions folder" you spoke of.)
No, it didn't.
BobJam wrote
You mean they don't post what you sent them, but rather post the previous "min/max" version as long as it passes their compatibility test?  (Thus it would show as incompatible with the new TB version e.g. "3.0 - 16*" would show as incompatible with TB 17.)
No. They do all correct except of notification emails. I'm afraid I cannot explain it more clearly. My English isn't good enough.

ajs
Reply | Threaded
Open this post in threaded view
|

Re: Date exactly one month off?

ajs
Hi

I know you're correcting this one-month out error but could you display as "d mmm yy h.mm am/pm" so that not only is there no confusion between your current mm/dd/yy and those of us who have been brought up with dd/mm/yy!

The time bit is unnecessarily precise and thus degrades the clarity of the timestamp.  Could also use "hhmm hrs" but, again, that might make many people stop and have to work out what the "real" time was!

BTW, I note that the Save button has disappeared, does that mean that anything you type is ALWAYS saved?

PS Overall, a VERY useful addition to Thunderbird.  In a perfect world, one would be able to simply edit within a message just like Outlook but this is a good second best.  Thank you
Reply | Threaded
Open this post in threaded view
|

Re: Date exactly one month off?

alehro
Administrator
ajs wrote
I know you're correcting this one-month out error but could you display as "d mmm yy h.mm am/pm" so that not only is there no confusion between your current mm/dd/yy and those of us who have been brought up with dd/mm/yy!
Good idea. Thanks. It will be in next release on AMO in a couple of weeks.

ajs wrote
The time bit is unnecessarily precise and thus degrades the clarity of the timestamp.  Could also use "hhmm hrs" but, again, that might make many people stop and have to work out what the "real" time was!
Well I'm a perfectionist and love seconds. Probably later I will make them optional.

ajs wrote
BTW, I note that the Save button has disappeared, does that mean that anything you type is ALWAYS saved?
Yes, it is. Speaking more precisely it is saved after two seconds when you stop typing note or when the cursor lives the note editing area. Practically it means ALWAYS and I haven't found situations when it isn't. If you find such a cases  then let me know please.

ajs wrote
In a perfect world, one would be able to simply edit within a message just like Outlook but this is a good second best.
So, you are saying that MNP functional is available in Outlook by default? I was wondering about porting the add-on to Outlook, but in such a case it isn't worth of trying.
ajs
Reply | Threaded
Open this post in threaded view
|

Re: Date exactly one month off?

ajs
"So, you are saying that MNP functional is available in Outlook by default? I was wondering about porting the add-on to Outlook, but in such a case it isn't worth of trying."

Yes, it was the only thing I missed when I left Outlook for Thunderbird!

It was very handy to be able to add a short comment at the top of someone's email or annotate within their email and then either store or print it.

Actually, I've just Print Previewed one of my emails that I've annotated with MNP and noticed that the Note doesn't appear on the Print.  Is it possible to have the Note appended to the bottom of the email (ie on the same sheet)?
Reply | Threaded
Open this post in threaded view
|

Re: Date exactly one month off?

alehro
Administrator
You are the second who wants print feature:
http://mnpforum.alehro00.com/Wanted-feature-print-facility-tp4638939.html
Unfortunately, I don't know how to do this.
Reply | Threaded
Open this post in threaded view
|

Re: Date exactly one month off?

alehro
Administrator
Great news! I've implemented printing feature . It  will be on AMO in a couple of weeks.